Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Add back-compat method to find options (styles) in angular.json #16832

Merged
merged 4 commits into from Dec 1, 2021

Conversation

ThibaudAV
Copy link
Contributor

TODO

Issue:

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Nov 30, 2021

Nx Cloud Report

CI ran the following commands for commit 96e28cf. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@ThibaudAV ThibaudAV force-pushed the angular-add-legacy-way-to-find-options branch 3 times, most recently from 8925741 to c637bde Compare November 30, 2021 08:19
@ThibaudAV ThibaudAV force-pushed the angular-add-legacy-way-to-find-options branch from c637bde to 49ef868 Compare November 30, 2021 08:20
@kroeder kroeder self-requested a review November 30, 2021 10:12
@kroeder kroeder added angular patch:yes Bugfix & documentation PR that need to be picked to main branch labels Nov 30, 2021
Comment on lines 145 to 146
logger.info(`=> TODO ~ legacy way to get default options`);
logger.info(`=> TODO ~ Add deprecation warning and ex for builder use ? `);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets remove those and merge the PR to hotfix the current issue and improve the situation afterwards

Suggested change
logger.info(`=> TODO ~ legacy way to get default options`);
logger.info(`=> TODO ~ Add deprecation warning and ex for builder use ? `);

Copy link

@Tim-arts Tim-arts Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here: "and wild be removed on Storybook 7.0"

Only matters if you're going to create the docs based on that

@kroeder
Copy link
Member

kroeder commented Nov 30, 2021

I tested it in my project that had this issue and it fixed it. Everything works as expected

@shilman shilman changed the title fix(angular): add backwards compatibility to find options (styles) in a fix structure of angular.json Angular: Add back-compat method to find options (styles) in angular.json Nov 30, 2021
@shilman shilman added the bug label Nov 30, 2021
@shilman
Copy link
Member

shilman commented Dec 1, 2021

@ThibaudAV @kroeder I did a little cleanup on the file and will merge/release an a 6.5 alpha. Once we get a few people testing it successfully we can patch the change back to 6.4. Sorry for meddling here but I feel this is time sensitive since people are upgrading to 6.4 now. 🙈

@shilman shilman marked this pull request as ready for review December 1, 2021 03:42
@shilman shilman merged commit 73de45c into next Dec 1, 2021
@shilman shilman deleted the angular-add-legacy-way-to-find-options branch December 1, 2021 03:42
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Dec 1, 2021
shilman added a commit that referenced this pull request Dec 1, 2021
…find-options

Angular: Add back-compat method to find options (styles) in angular.json
@ThibaudAV
Copy link
Contributor Author

Ok I will add the message of deprecation of this code for v7 and the info in the MIGRATION.md in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants