UI: Ensure all classes+animations for our loaders are prefixed #16815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit 32e3bb6. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
MichaelArestad
approved these changes
Nov 30, 2021
|
@tmeasday should i merge or are we going to back all of this out? |
|
We are going to keep it, you can definitely merge. |
shilman
changed the title
shilman
added
patch:yes
shilman
added a commit
that referenced
this pull request
Dec 1, 2021
…-styles UI: Ensure all classes+animations for our loaders are prefixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16545
What I did
Added a
sb-prefix to all the styles / animations we add in the preview.How to test
Remove
.sb-show-main, add.sb-show-preparing-docsto a preview.