Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Sort the results of globby when constructing Story Index #16788

Merged
merged 3 commits into from Nov 26, 2021

Conversation

tmeasday
Copy link
Member

Issue: #16767

What I did

Sort globbed files for consistent ordering.

Apparently globby's order is non deterministic: sindresorhus/globby#131

I wasn't able to reproduce in our tests but definitely saw the behaviour in @yannbf's reproduction.

How to test

I verified it fixes by changing the source in the reproduction.

  • Is this testable with Jest or Chromatic screenshots?

I couldn't make the tests reproduce the problem, so not really.

For #16767

Apparently globby's order is non deterministic: sindresorhus/globby#131

I wasn't able to reproduce in our tests but definitely saw the behaviour in the issue.
@nx-cloud
Copy link

nx-cloud bot commented Nov 25, 2021

Nx Cloud Report

CI ran the following commands for commit 044f731. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman changed the title Sort the results of globby when constructing Story Index Core: Sort the results of globby when constructing Story Index Nov 26, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snapshot seems to be failing in CI?

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants