Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc: Cleanup typescript webpack types #16780

Merged
merged 1 commit into from Nov 25, 2021
Merged

Misc: Cleanup typescript webpack types #16780

merged 1 commit into from Nov 25, 2021

Conversation

ndelangen
Copy link
Member

Issue: #15336

What I did

I removed a few references to webpack types which are likely incorrect
I updated a few imports to be clear they are type-interfaces

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

@ndelangen ndelangen self-assigned this Nov 24, 2021
@ndelangen
Copy link
Member Author

@kroeder are you able to review?

@nx-cloud
Copy link

nx-cloud bot commented Nov 24, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit bbd7262. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

kroeder
kroeder approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@kroeder kroeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! I totally forgot that there is import type

@shilman shilman added maintenance User-facing maintenance tasks typescript labels Nov 25, 2021
@shilman shilman changed the title cleanup typescript webpack types Misc: Cleanup typescript webpack types Nov 25, 2021
@shilman shilman merged commit 69e9742 into next Nov 25, 2021
@shilman shilman deleted the tech/15336-cleanup-webpack-types branch November 25, 2021 11:33
@shilman shilman added this to the 6.4 PRs milestone Nov 25, 2021
@shilman shilman mentioned this pull request Nov 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroeder kroeder kroeder approved these changes

Assignees

@ndelangen ndelangen

Labels
maintenance User-facing maintenance tasks typescript
Projects
None yet
Milestone
6.4 PRs
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ndelangen @kroeder @shilman