Controls: Remove ArrayControl #15788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonspalmer
added
maintenance
Nx Cloud ReportCI ran the following commands for commit f011a67. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
jonspalmer
commented
Aug 7, 2021
| @@ -80,7 +75,6 @@ export type ControlType = | |||
| | 'text'; | |||
|
|
|||
| export type Control = | |||
| | ArrayConfig | |||
There was a problem hiding this comment.
I suspect that technically this is a breaking change. Consumers could have been passing a separator param which has been ignored since we switched to ObjectControl. Do we want a deprecation warning around this or just do it?
shilman
approved these changes
Aug 8, 2021
| @@ -80,7 +75,6 @@ export type ControlType = | |||
| | 'text'; | |||
|
|
|||
| export type Control = | |||
| | ArrayConfig | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The ArrayControl was replace with the ObjectControl in 6.2 - f0cf8bab. This cleans up the now unused code.