New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Button to accept href attribute #15671
Conversation
Nx Cloud ReportCI ran the following commands for commit addac42. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
Nx Cloud ReportWe didn't find any information for the current pull request with the commit addac42. Check the Getting started section to configure the app. Sent with 💌 from NxCloud. |
This is blocking work for the referenced issue -- if we can approve early next week I would be very happy ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems good to me, although I fully agree with you about using buttons as links 💯
This looks good to me. I also have opinions on links disguised as buttons, but generally speaking, there is a time and place for it and we should do it sparingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Issue: N/A
References: #4667
What I did
While I am strongly against the practice of having links appear as buttons (and vice versa), this PR aims to fix a TypeScript error when trying to use
<Button isLink />
.How to test
yarn build --core
,yarn start
href
propIf your answer is yes to any of these, please make sure to include it in your PR.