Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular: Fix void element selectors #15495

Merged
merged 1 commit into from Jan 10, 2022
Merged

Angular: Fix void element selectors #15495

merged 1 commit into from Jan 10, 2022

Conversation

stefan-schweiger
Copy link
Contributor

Issue: #15494

What I did

Check during buildTemplate if the element is a void element and use a different replacement strategy for it.

How to test

  • Is this testable with Jest or Chromatic screenshots?
    I've added two basic jest tests for this

@nx-cloud
Copy link

nx-cloud bot commented Jul 6, 2021 •
edited

☁️ Nx Cloud Report

CI ran the following commands for commit c6ef520. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@admosity admosity mentioned this pull request Nov 15, 2021
Closed
@manuelmeister
Copy link
Contributor

@ThibaudAV I think, this PR/issue would be appreciated.

@shilman shilman requested a review from a team December 6, 2021 12:41
@ThibaudAV
Copy link
Contributor

good catch and thanks for the change request ❤️

@stale
Copy link

stale bot commented Jan 9, 2022

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jan 9, 2022
@stefan-schweiger
Copy link
Contributor Author

@ThibaudAV what would be needed to merge this PR?

@stale stale bot removed the inactive label Jan 9, 2022
@ThibaudAV
Copy link
Contributor

@stefan-schweiger can you look at my proposal here? #15495 (comment)

@stefan-schweiger
Copy link
Contributor Author

@ThibaudAV looks good to me, I've just accepted the changes 😉

@stefan-schweiger
Copy link
Contributor Author

@shilman any chance to get this into 6.5?

@shilman shilman changed the title Fix void element selectors for angular Angular: Fix void element selectors Jan 10, 2022
@shilman
Copy link
Member

shilman commented Jan 10, 2022 •
edited

@stefan-schweiger Happy to merge this once CI is passing. Can you please take a look at the failing unit tests? Let me know if you need any help

@stefan-schweiger
Copy link
Contributor Author

stefan-schweiger commented Jan 10, 2022 •
edited

I'm not entirely sure what happend just now. I was just trying to merge back the current upstream/next branch. I will probably create a new PR. Just give me a second.

@stefan-schweiger
Copy link
Contributor Author

@shilman ok I think now everything should be back in order again. (At least as far as I can tell the broken e2e tests aren't my fault)

Would it now be possible to merge this?

shilman
shilman approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit fc03acf into storybookjs:next Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThibaudAV ThibaudAV ThibaudAV left review comments

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
angular bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stefan-schweiger @manuelmeister @ThibaudAV @shilman