Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions: Don't override existing action args #15394

Merged
merged 1 commit into from Jun 28, 2021

Conversation

tmeasday
Copy link
Member

Issue: #15370

What I did

Update actions args enhancer to not override existing (defined) value.

How to test

See jest tests

@tmeasday tmeasday requested a review from shilman June 28, 2021 06:13
@tmeasday tmeasday added the bug label Jun 28, 2021
@nx-cloud
Copy link

nx-cloud bot commented Jun 28, 2021

Nx Cloud Report

CI ran the following commands for commit 020b10f. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@shilman shilman changed the title Don't override existing action args Actions: Don't override existing action args Jun 28, 2021
@shilman shilman added addon: actions patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 28, 2021
@shilman shilman merged commit 203ef37 into next Jun 28, 2021
@shilman shilman deleted the 15370-dont-override-existing-action-args branch June 28, 2021 07:30
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 28, 2021
shilman added a commit that referenced this pull request Jun 28, 2021
…ng-action-args

Actions: Don't override existing action args
@quangv
Copy link

quangv commented Jun 28, 2021

Awesome! Thanks @tmeasday and @shilman !

@shilman shilman added this to the 6.4 PRs milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: actions bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants