Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSF3: Rename setup to play #15358

Merged
merged 1 commit into from Jun 25, 2021
Merged

CSF3: Rename setup to play #15358

merged 1 commit into from Jun 25, 2021

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 25, 2021

Issue: N/A

What I did

Rename CSF3's setup function to play.

  • Setup implies something that happens before the render function.
  • Play implies a script that can be played/paused/re-played.

How to test

  • See AccountForm stories in examples/react-ts
  • See attached tests

@shilman shilman added maintenance User-facing maintenance tasks csf BREAKING PRERELEASE labels Jun 25, 2021
@nx-cloud
Copy link

nx-cloud bot commented Jun 25, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit bd90a23. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@nx-cloud
Copy link

nx-cloud bot commented Jun 25, 2021

Nx Cloud Report

We didn't find any information for the current pull request with the commit bd90a23.
Please make sure you set the \ NX_BRANCH\ environment variable in your CI pipeline .

Check the Getting started section to configure the app.

Sent with 💌 from NxCloud.

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 25, 2021
tmeasday
tmeasday approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@shilman shilman merged commit 0b81fe1 into next Jun 25, 2021
@shilman shilman deleted the csf3-rename-setup-to-play branch June 25, 2021 07:34
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 28, 2021
shilman added a commit that referenced this pull request Jun 28, 2021
@shilman
Merge pull request #15358 from storybookjs/csf3-rename-setup-to-play
42bc83a 
CSF3: Rename setup to play
@shilman shilman added this to the 6.4 PRs milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
csf maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
6.4 PRs
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shilman @tmeasday