Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-server): build config inconsistency #14566

Merged
merged 1 commit into from Apr 13, 2021
Merged

fix(core-server): build config inconsistency #14566

merged 1 commit into from Apr 13, 2021

Conversation

lihbr
Copy link
Contributor

@lihbr lihbr commented Apr 12, 2021

Issue: #14561 (more info there), nuxt-community/storybook#259

buildDev() and buildStatic() don't resolve the configDir option the same way:

What I did

Made configDir resolve strategy the same as in: https://github.com/storybookjs/storybook/blob/next/lib/core-server/src/build-static.ts#L110

How to test

  • Is this testable with Jest or Chromatic screenshots? n/a
  • Does this need a new example in the kitchen sink apps? n/a
  • Does this need an update to the documentation? n/a

Additional context

Was unable to run tests on Windows because they seem to rely on POSIX paths where my machine uses win32 ones. However I checked before/after and consistently have the same amount of test "failing" because of that.

cc @ndelangen

@ndelangen ndelangen added bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 12, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lihbr !!!

@shilman shilman merged commit 5875a03 into storybookjs:next Apr 13, 2021
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 14, 2021
shilman added a commit that referenced this pull request Apr 14, 2021
…onsistency

fix(core-server): build config inconsistency
@lihbr lihbr deleted the fix/core-server-build-config-inconsistency branch April 14, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants