fix(core-server): build config inconsistency #14566
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #14561 (more info there), nuxt-community/storybook#259
buildDev()
andbuildStatic()
don't resolve theconfigDir
option the same way:buildDev()
configuration resolver: https://github.com/storybookjs/storybook/blob/next/lib/core-server/src/build-dev.ts#L122buildStatic()
configuration resolver: https://github.com/storybookjs/storybook/blob/next/lib/core-server/src/build-static.ts#L110What I did
Made
configDir
resolve strategy the same as in: https://github.com/storybookjs/storybook/blob/next/lib/core-server/src/build-static.ts#L110How to test
Additional context
Was unable to run tests on Windows because they seem to rely on POSIX paths where my machine uses win32 ones. However I checked before/after and consistently have the same amount of test "failing" because of that.
cc @ndelangen