Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: properly detect vuetify3 #14552

Merged

Conversation

morphatic
Copy link
Contributor

Issue: Vuetify 3 alpha for Vue 3 was released 2021-03-03. npx sb init no longer detects the correct type for projects using Vuetify v3.

What I did

Updated ProjectType.SFC_VUE in ./lib/cli/src/project_types.ts to match ONLY for vue-loader < v16 and vuetify < v3.

How to test

  1. Make sure to rebuild storybook from local clone
  2. Use @vue/cli to create a new Vue 3 app: vue create myApp
  3. cd into the app directory: cd myApp
  4. Use the Vue CLI to add Vuetify 3: vue add vuetify, select v3 alpha from the options
  5. Run /path/to/storybook/lib/cli/bin/index.js init
  6. Confirm that sb runs: npm run storybook
  • Is this testable with Jest or Chromatic screenshots? No
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

@shilman shilman added vue cli patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 12, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix @morphatic!

@shilman shilman merged commit 1a869cd into storybookjs:next Apr 12, 2021
@shilman shilman added bug patch:done Patch/release PRs already cherry-picked to main/release branch labels Apr 13, 2021
shilman added a commit that referenced this pull request Apr 14, 2021
…s-vuetify3

CLI: properly detect vuetify3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants