Controls: Reset ArgsTable state when switching stories #14493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeasday
reviewed
Apr 7, 2021
| @@ -36,6 +37,7 @@ export const ControlsPanel: FC = () => { | |||
| {showWarning && <NoControlsWarning />} | |||
| <ArgsTable | |||
| {...{ | |||
| key: path, // resets state when switching stories | |||
There was a problem hiding this comment.
Would storyId make more sense here?
There was a problem hiding this comment.
Yeah I did that at first but it would then have to be:
{
key: refId ? `${refId}_${storyId}` : storyId
}path achieves the same thing but without the added complexity of dealing with refId (it's in the path already).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #14474
What I did
Added the
keyprop to force React to create a fresh component rather than reuse a previous instance.Added a missing dependency to
useCallbackin two places which could lead to the wrong onChange handler getting called.This also fixes a similar issue with the JSON raw editor using stale data when switching stories.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.