Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix config.js-based configuration #14479

Merged
merged 1 commit into from Apr 5, 2021

Conversation

shilman
Copy link
Member

@shilman shilman commented Apr 5, 2021

Issue: #14458

What I did

Don't try to require main.js when the file doesn't exist

self-merging @ndelangen

How to test

cd examples/react-ts
# replace main.js with config.js
yarn storybook 
// config.js
import { configure } from '@storybook/react';
configure(require.context('./src', true, /\.stories\..*/), module);

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2021

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies","other"]

Generated by 🚫 dangerJS against 8ba39ae

@shilman shilman added this to the 6.2 stabilization milestone Apr 5, 2021
@shilman shilman merged commit e65d987 into next Apr 5, 2021
@shilman shilman deleted the 14458-fix-configjs-configuration branch April 5, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant