Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs/Angular: Keep inlineStories to false by default #14447

Merged
merged 1 commit into from Apr 2, 2021

Conversation

ThibaudAV
Copy link
Contributor

@ThibaudAV ThibaudAV commented Apr 2, 2021

Issue:

馃檲 multiple reverts and bounces of this subject have lost a small essential change

What I did

keep a inlineStories = false as expected ...

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

image

@ThibaudAV ThibaudAV marked this pull request as ready for review April 2, 2021 08:40
@shilman shilman changed the title Angular: keep inlineStories to false by default Angular: Keep inlineStories to false by default Apr 2, 2021
@shilman shilman changed the title Angular: Keep inlineStories to false by default Addon-docs/Angular: Keep inlineStories to false by default Apr 2, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants