Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React: Don't add FastRefresh if already enabled #13303

Merged
merged 2 commits into from Nov 27, 2020
Merged

React: Don't add FastRefresh if already enabled #13303

merged 2 commits into from Nov 27, 2020

Conversation

tooppaaa
Copy link
Contributor

Issue: #13248

What I did

  • Name babel plugin
  • Remove plugin if already set (I don't like how I removed it, any better ideas ? @mrmckeb WDYT ?)

How to test

  • CRA with fastRefresh enabled

@shilman shilman changed the title React: Remove FastRefresh if already enabled React: Don't add FastRefresh if already enabled Nov 27, 2020
@shilman shilman added this to the 6.1.x milestone Nov 27, 2020
@shilman shilman merged commit b466006 into next Nov 27, 2020
@shilman shilman deleted the fix/fastRefreshCRA branch November 27, 2020 01:32
@shilman shilman mentioned this pull request Nov 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman Awaiting requested review from shilman

@thomasbertet thomasbertet Awaiting requested review from thomasbertet

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

Assignees
No one assigned
Labels
bug react
Projects
None yet
Milestone
6.1.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tooppaaa @shilman