Addon-docs: Fix Vue source snippets for function attributes #13288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to the excellent work done in #12812 by @pocka
What I did
The
sourceDecorator
currently throws an error if for some reason the value of an attribute is a function so I've added a simple check for the typeof the value:I'm not sure what the underlying issue is that causes the type to be a function but it seems to be related to event handlers.
Here's some example code for a component/story (Not committed to the repo as it breaks storyshot tests) that causes the source to not be generated.
Example component:
For some reason the value of the
@previous-page
attribute is being passed through as a function instead of just being undefined like@next-page
:How to test
If your answer is yes to any of these, please make sure to include it in your PR. ... done (
addons/docs/src/frameworks/vue/sourceDecorator.test.ts
)