New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-docs: Fix type aliases and enum types from Angular Compodoc JSON #12665
Conversation
Should I update the documentation for this? I'm trying to think if the detail should go in the docs for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @lachieh! Thanks for your patience on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @lachieh! Thanks for your patience on this!
Thank you! |
Issue: #12531
What I did
Added functionality to resolved type aliases and extract enum types from the compodoc generated json file
How to test
Is this testable with Jest or Chromatic screenshots?
Added test cases for named enum types
Does this need a new example in the kitchen sink apps?
Yes, there is a new Enum example component
Does this need an update to the documentation?
Possibly. I was not able to get the base Enum type with auto-incrementing number values to work correctly. It will generate the select input, though switching between the values does not update the component.