Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Move summary & detail equality check to createSummaryValue #12588

Merged

Conversation

phated
Copy link
Contributor

@phated phated commented Sep 26, 2020

Issue: N/A

What I did

I moved the summary and detail equality comparison into the createSummaryValue utility function and cleaned up the call sites that were checking equality themselves. I also added Jest tests for this util method.

This also lays some groundwork for a bigger Flow related PR that I've been working on.

How to test

  • Is this testable with Jest or Chromatic screenshots? Jest, added a new test file!
  • Does this need a new example in the kitchen sink apps? Nope
  • Does this need an update to the documentation? Nope

If your answer is yes to any of these, please make sure to include it in your PR.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit e98574c into storybookjs:next Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants