Web Components: Add script tag support #12509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I extracted the simulate-pageload to client-api in #12522. Would be great to take advantage of that for this PR. |
shilman
requested changes
Sep 20, 2020
There was a problem hiding this comment.
Thanks @zolk, looks great!! Can you please update to take advantage of @jonspalmer 's refactor? 🙏
zolk
force-pushed
the
feat/wc-script
branch
from
fc2ef48
to
611a5ae
Compare
Updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the example of #12089 for HTML, this adds
<script>tag support for Web Components.Not sure if we want to move
simulate-pageload.tsinto a shared location rather including a separate copy with each app?How to test
Example stories have been added to
web-components-kitchen-sinkinscript.stories.js, one rendered withlit-htmland another as a basic string.