Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-actions: Fix log flushing when story re-renders #12500

Merged
merged 1 commit into from Sep 24, 2020
Merged

Addon-actions: Fix log flushing when story re-renders #12500

merged 1 commit into from Sep 24, 2020

Conversation

y-nk
Copy link
Contributor

@y-nk y-nk commented Sep 17, 2020

Issue: #12437

What I did

  • Followed @tmeasday instructions on how to fix the issue

How to test

  • Is this testable with Jest or Chromatic screenshots? Nope
  • Does this need a new example in the kitchen sink apps? I don't think so
  • Does this need an update to the documentation? Definitely not

If your answer is yes to any of these, please make sure to include it in your PR.

@y-nk y-nk added the bug label Sep 17, 2020
@y-nk y-nk requested a review from ndelangen September 17, 2020 07:10
@y-nk y-nk changed the title changed storybook event to avoid flush action when control updates Fixes: Issue #12437 (action logger should not flush when story re-renders) Sep 17, 2020
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y-nk
Copy link
Contributor Author

y-nk commented Sep 18, 2020

@tmeasday thanks 🙏
can this be merged/released soon?

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@shilman shilman changed the title Fixes: Issue #12437 (action logger should not flush when story re-renders) Addon-actions: Fix action logger flushing when story re-renders Sep 24, 2020
@shilman shilman changed the title Addon-actions: Fix action logger flushing when story re-renders Addon-actions: Fix log flushing when story re-renders Sep 24, 2020
@shilman shilman modified the milestones: 6.0.x, 6.1 essentials Sep 24, 2020
@shilman shilman merged commit acdb41c into storybookjs:next Sep 24, 2020
@y-nk y-nk deleted the fix/actions-flush-on-rerender branch September 29, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants