Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Add CRA benchmark #12209

Merged
merged 5 commits into from Aug 31, 2020
Merged

Build: Add CRA benchmark #12209

merged 5 commits into from Aug 31, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 24, 2020 •
edited

Issue: N/A

What I did

Add CRA clean install + sb init benchmark to CI

How to test

Results available as a data studio report:

https://datastudio.google.com/reporting/c34f64ee-400f-4d06-ad4f-5c2133e226da

@shilman shilman added maintenance User-facing maintenance tasks performance issue labels Aug 25, 2020
@shilman shilman marked this pull request as ready for review August 30, 2020 09:45
tmeasday
tmeasday approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Do we need to document somewhere what environment variables need to be set for this to work and where the data is viewable?

@ndelangen
Copy link
Member

Does the datastudio reporting happen on CI only?

Contributors' machines will vary in speed.

@shilman
Copy link
Member Author

shilman commented Aug 31, 2020

  • Updated @storyook/bench README per @tmeasday comment
  • Made GCP upload only happen on CI

@shilman shilman merged commit 09b75a3 into next Aug 31, 2020
@shilman shilman deleted the tech/benchmark branch August 31, 2020 11:35
@shilman shilman added this to the 6.0.x milestone Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

@igor-dv igor-dv Awaiting requested review from igor-dv

@ndelangen ndelangen Awaiting requested review from ndelangen

@ghengeveld ghengeveld Awaiting requested review from ghengeveld

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks performance issue
Projects
None yet
Milestone
6.0.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shilman @ndelangen @tmeasday