Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Fix missing line-height on TypeSet block #12134

Merged
merged 1 commit into from Sep 5, 2020
Merged

Addon-docs: Fix missing line-height on TypeSet block #12134

merged 1 commit into from Sep 5, 2020

Conversation

jpzwarte
Copy link
Member

Add line-height to <TypeSet> <Sample>. Fixes screenshot:
Screen Shot 2020-08-19 at 13 26 16

@ndelangen ndelangen requested a review from domyen August 24, 2020 12:41
@ndelangen ndelangen added this to the 6.0.x milestone Aug 24, 2020
@jpzwarte
Copy link
Member Author

To be clear: I'm changing the line-height of the preview in preview-head.html. If you don't do that, then line-height will use the default value and this bug does not appear.

shilman
shilman approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @domyen?

@ndelangen
Copy link
Member

The new situation is at least better than the old? Can we merge and refine later if @domyen has remarks?

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Sep 5, 2020
@shilman shilman changed the title Add missing line-height to <TypeSet>. Addon-docs: Add missing line-height to TypeSet block Sep 5, 2020
@shilman shilman changed the title Addon-docs: Add missing line-height to TypeSet block Addon-docs: Fix missing line-height on TypeSet block Sep 5, 2020
@shilman shilman merged commit 9326e4d into storybookjs:next Sep 5, 2020
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Sep 26, 2020
shilman added a commit that referenced this pull request Sep 26, 2020
@shilman
Merge pull request #12134 from jpzwarte/add-missing-line-height-to-ty…
79c1467 
…peset

Addon-docs: Fix missing line-height on TypeSet block
@shilman shilman mentioned this pull request Oct 16, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@ndelangen ndelangen ndelangen approved these changes

@tmeasday tmeasday Awaiting requested review from tmeasday

@domyen domyen Awaiting requested review from domyen

Assignees

@domyen domyen

Labels
addon: docs block: other bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
6.0.x
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jpzwarte @ndelangen @shilman @domyen