Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: CORS issues on Standalone server #9348

Closed
shilman opened this issue Jan 7, 2020 · 3 comments
Closed

Addon-docs: CORS issues on Standalone server #9348

shilman opened this issue Jan 7, 2020 · 3 comments
Assignees
@shilman @patricklafrance @atanasster
Labels
addon: docs bug
Milestone
5.3.0

Comments

@shilman
Copy link
Member

shilman commented Jan 7, 2020

When manager/preview run on different ports or domains, it triggers a CORS issue due to some hacked up preview code.

This commit patches over the issue: c8faee0

However, a superior fix would be to use the channel that we already have available to allow the preview to post an event to the manager to ask it to set the anchor in the URL.
@shilman shilman added this to the 5.3.0 milestone Jan 7, 2020
@atanasster
Copy link
Member

How can I reproduce this?

@atanasster atanasster mentioned this issue Jan 7, 2020
Closed
@shilman
Copy link
Member Author

shilman commented Jan 8, 2020 •
edited

Repro: Run standalone mode with docs enabled #7848

@atanasster
Copy link
Member

should be fixed in rc13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shilman shilman

@patricklafrance patricklafrance

@atanasster atanasster

Labels
addon: docs bug
Projects
None yet
Milestone
5.3.0
Development

No branches or pull requests
3 participants
@shilman @patricklafrance @atanasster