Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acorn transpiling destabilizes webpack config in corner cases #9089

Closed
shilman opened this issue Dec 7, 2019 · 2 comments
Closed

Acorn transpiling destabilizes webpack config in corner cases #9089

shilman opened this issue Dec 7, 2019 · 2 comments

Comments

@shilman
Copy link
Member

shilman commented Dec 7, 2019

#9021 introduces babel transpiling of a specific folder. This is a small change, but it can break webpack configurations that depend on the user's configuration, e.g.

https://github.com/evergarden-ui/evergarden/blob/9948cdbab4e8f1c090955974b221db5ce159ba46/packages/evergarden/.storybook/webpack.config.js

Since the acorn dep is ours, is there a better way to transpile it?

I've resolved the issue in the evergarden code for now, and I realize this is not a common case, but it seems like something that could be confusing for other users in the future.

@stale
Copy link

stale bot commented Dec 28, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Dec 28, 2019
@stale
Copy link

stale bot commented Jan 27, 2020

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant