Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-a11y: CI support #8845

Closed
Peeja opened this issue Nov 15, 2019 · 5 comments
Closed

Addon-a11y: CI support #8845

Peeja opened this issue Nov 15, 2019 · 5 comments

Comments

@Peeja
Copy link
Contributor

Peeja commented Nov 15, 2019

We'd like our components to be accessible, so we use the a11y-addon. But it's easy to forget to look at that all the time. Having the result in CI (or even better, in a command that can also run locally from the command line) would help a lot to make sure we cover our bases.

I see that that's on the roadmap already. Has the path to get there been thought out yet? If I were to try to make that happen, as someone not at all familiar with the code yet, is there anything I should know going in?

@shilman shilman changed the title What would it take to implement CI support for a11y-addon? Addon-a11y: CI support Nov 15, 2019
@shilman
Copy link
Member

shilman commented Nov 15, 2019

@Peeja this would be amazing! You might take a look at storyshots as an example of a standalone CI process that uses storybook's story store?

https://github.com/storybookjs/storybook/tree/next/addons/storyshots

@diegoNutmeg
Copy link

+1

@shilman
Copy link
Member

shilman commented Dec 6, 2019

FYI, this appears to be work in progress by @Hypnosphi here: #8934

@Hypnosphi
Copy link
Member

It's actually ready to use with current beta, see https://github.com/storybookjs/storybook/tree/next/addons/storyshots/storyshots-puppeteer#axetest

@stale
Copy link

stale bot commented Dec 27, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants