Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocPage: Prop table does not appear in the Docs panel if a component is exported wrapped in a React.memo function #8361

Closed
jeremytenjo opened this issue Oct 9, 2019 · 9 comments

Comments

@jeremytenjo
Copy link

Describe the bug
Proptypes tabel does not appear in the Docs panel if a component is exported wrapped in a memo function.

For example
export default React.memo(Button)

To Reproduce
Steps to reproduce the behavior:

  1. Create regular React component
  2. Export component wrapped in React.memo function
  3. Run storybook
  4. Open Doc panel
  5. The prop table does not appear.

Expected behavior
The prop table does appears when component exported wrapped in React.mem()

@jeremytenjo jeremytenjo changed the title DocPage: Proptypes do not appear in the Docs panel if a component is exported wrapped in a memo function DocPage: Prop table does not appear in the Docs panel if a component is exported wrapped in a React.memo function Oct 9, 2019
@shilman
Copy link
Member

shilman commented Oct 10, 2019

Related: #7933

@qooban
Copy link

qooban commented Oct 30, 2019

In my case (component wrapped with React.memo) props documentation is not displayed automatically. I used this workaround #8435 (comment) (exporting wrapped component) and now props are displayed fine.

@patricklafrance
Copy link
Member

@shilman

This should be fixed by #8665

@AntonDolgov
Copy link

AntonDolgov commented Nov 8, 2019

Similar problem with forwardRef. The code and the "docs" tab:

Without forwardRef:

Screenshot at Nov 08 17-08-21
Screenshot at Nov 08 17-11-13

With forwardRef:

Screenshot at Nov 08 17-13-15
Screenshot at Nov 08 17-14-40

Version:

Screenshot at Nov 08 17-09-21

presets.js

Screenshot at Nov 08 17-34-00

@shilman
Copy link
Member

shilman commented Nov 26, 2019

Unsatisfying workaround is to also export your pure component and use that for documentation purposes 😭

@stale
Copy link

stale bot commented Dec 17, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale
Copy link

stale bot commented Jan 16, 2020

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Jan 16, 2020
@lughino
Copy link

lughino commented Feb 18, 2020

This issue seems to be still unfixed but the stale bot closed it. Any updates?

@shilman
Copy link
Member

shilman commented Feb 18, 2020

Dupe to #9586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants