Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Better error handling for configure #7935

Closed
shilman opened this issue Aug 30, 2019 · 1 comment
Closed

Addon-docs: Better error handling for configure #7935

shilman opened this issue Aug 30, 2019 · 1 comment
Assignees
@shilman
Labels
csf maintenance User-facing maintenance tasks
Milestone
5.2.x

Comments

@shilman
Copy link
Member

shilman commented Aug 30, 2019 •
edited

The new configure expects a module argument. If you forget to pass the module, the framework gets passed as the module, and it's really hard to debug what's going on. So we should just test to make sure that there's a module and fail fast.

h/t @justinanastos 🙌
@shilman shilman added maintenance User-facing maintenance tasks csf labels Aug 30, 2019
@shilman shilman added this to the 5.2.0 milestone Aug 30, 2019
@shilman shilman self-assigned this Aug 30, 2019
@stale stale bot added the inactive label Sep 20, 2019
@shilman shilman modified the milestones: 5.2.0, 5.2.x Sep 23, 2019
@stale stale bot removed inactive labels Sep 23, 2019
@stale stale bot added the inactive label Oct 14, 2019
@shilman shilman mentioned this issue Oct 14, 2019
Merged
@stale stale bot removed the inactive label Oct 14, 2019
@storybookjs storybookjs deleted a comment from stale bot Oct 14, 2019
@storybookjs storybookjs deleted a comment from stale bot Oct 14, 2019
@shilman
Copy link
Member Author

shilman commented Oct 19, 2019

Ta-da!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.0-alpha.23 containing PR #8412 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shilman shilman

Labels
csf maintenance User-facing maintenance tasks
Projects
None yet
Milestone
5.2.x
Development

No branches or pull requests
1 participant
@shilman