Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-info doesn't work with --preview-url set up #7514

Closed
Eoksni opened this issue Jul 21, 2019 · 9 comments
Closed

Addon-info doesn't work with --preview-url set up #7514

Eoksni opened this issue Jul 21, 2019 · 9 comments

Comments

@Eoksni
Copy link

Eoksni commented Jul 21, 2019

Describe the bug
Adding addon-info (dunno, maybe it concerns ANY addon, not just addon-info)

import { withInfo } from "@storybook/addon-info";

addDecorator(withInfo);

to the configuration of preview makes it break - in the browser it shows infinite loading state and in console there is an error

Uncaught Error: Cannot find module './lib/nestedObjectAssign.js'
    at newRequire (storybook-with-info.dd8dc941.js:37)
    at localRequire (storybook-with-info.dd8dc941.js:53)
    at Object.parcelRequire.../node_modules/nested-object-assign/index.js../package.json (storybook-with-info.dd8dc941.js:44153)
    at newRequire (storybook-with-info.dd8dc941.js:47)
    at localRequire (storybook-with-info.dd8dc941.js:53)
    at Object.parcelRequire.../node_modules/@storybook/addon-info/dist/index.js.core-js/modules/es.object.assign (storybook-with-info.dd8dc941.js:76621)
    at newRequire (storybook-with-info.dd8dc941.js:47)
    at localRequire (storybook-with-info.dd8dc941.js:53)
    at Object.parcelRequire.storybook-with-info.js.react (storybook-with-info.dd8dc941.js:76741)
    at newRequire (storybook-with-info.dd8dc941.js:47)
17:01:25.410 

To Reproduce
Check the minimal setup to reproduce https://github.com/Eoksni/poc-storybook-preview

Expected behavior
I expect addon-info to be loaded without errors.

System:

  • OS: Windows10
  • Device: PC
  • Browser: chrome
  • Framework: react
  • Addons: addon-info
  • Version: 5.2.0-beta.5
@stale
Copy link

stale bot commented Aug 11, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@shilman
Copy link
Member

shilman commented Aug 26, 2019

FYI addon-info is being superceded by addon-docs, which fixes a bunch of bugs and is easier to maintain. It’s reached release candidate (RC) status and will be properly released soon. Please give it a try! https://medium.com/storybookjs/storybook-docspage-e185bc3622bf

@shilman
Copy link
Member

shilman commented Aug 26, 2019

Also, here's a version of docs that works with --preview-url: #7848

@stale
Copy link

stale bot commented Sep 16, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Sep 16, 2019
@shilman shilman modified the milestones: 5.2.0, 5.2.x Sep 23, 2019
@stale stale bot removed the inactive label Sep 23, 2019
@stale
Copy link

stale bot commented Oct 14, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Oct 14, 2019
@stale
Copy link

stale bot commented Nov 13, 2019

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Nov 13, 2019
@esr360
Copy link

esr360 commented Feb 15, 2020

I'm not sure what the solution to this problem is but I'm facing it.

@shilman
Copy link
Member

shilman commented Feb 16, 2020

Addon-info is unmaintained (contributions always welcome!) and has been moved out of the monorepo in 6.0. Addon-docs is the recommended documentation solution for Storybook, includes most if not all of addon-info's features, and is getting better with each release: https://medium.com/storybookjs/storybook-docspage-e185bc3622bf

@shilman
Copy link
Member

shilman commented Jul 7, 2021

Yowza!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.0-alpha.12 containing PR #7848 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants