Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-a11y: Show "incompletes" in a tab #5782

Closed
shilman opened this issue Feb 27, 2019 · 7 comments
Closed

Addon-a11y: Show "incompletes" in a tab #5782

shilman opened this issue Feb 27, 2019 · 7 comments

Comments

@shilman
Copy link
Member

shilman commented Feb 27, 2019

Currently addon-a11y displays passes and fails. However, the underly library we use also returns "incompletes" that could not determined to be passed or failed. We should show these in a tab!

Hat tip to @gaetanmaisse for the feature suggestion: #5774 (comment)

@Armanio
Copy link
Member

Armanio commented Mar 5, 2019

Hmm, intresting.
Can i do it?

@gaetanmaisse
Copy link
Member

gaetanmaisse commented Mar 5, 2019

Sure @Armanio! But I think we should wait to merge #5738. I will resolve conflicts this week and check with @shilman when we can merge it.

@Armanio
Copy link
Member

Armanio commented Mar 5, 2019

Got it!

@shilman
Copy link
Member Author

shilman commented Mar 6, 2019

@gaetanmaisse we can merge whenever conflicts are resolved 👍 thanks for checking!

@gaetanmaisse
Copy link
Member

@Armanio #5738 is merged so you can have fun with addon-a11y now!

@Armanio
Copy link
Member

Armanio commented Mar 9, 2019

Ready! Check it!

@shilman
Copy link
Member Author

shilman commented Mar 9, 2019

Yowza!! I just released https://github.com/storybooks/storybook/releases/tag/v5.1.0-alpha.3 containing PR #5984 that references this issue. Upgrade today to try it out!

Because it's a pre-release you can find it on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants