Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Rax framework #4797

Closed
hoanguyen311 opened this issue Nov 16, 2018 · 5 comments
Closed

Add support for Rax framework #4797

hoanguyen311 opened this issue Nov 16, 2018 · 5 comments

Comments

@hoanguyen311
Copy link

hoanguyen311 commented Nov 16, 2018

Is your feature request related to a problem? Please describe.
I'm very interested in this project and want to apply it for my tasks in company but it lacks of support for Rax which is the framework I'm using.

https://github.com/alibaba/rax

Describe the solution you'd like
Can you add support for this framework?

Describe alternatives you've considered
Provide a guideline for adding framework support so I can contribute.

Are you able to assist bring the feature to reality?
yes, I can do it if there is a guideline.

@igor-dv
Copy link
Member

igor-dv commented Nov 17, 2018

Hey @hoanguyen311, we do not have any formal guideines for a new framework support, but you can take a look on the last PR (#4237) for ember.

Also, you can talk with us on Discord if you need any help =)
You can just open a PR with some minimal working POC, and we will guide you.

@broven
Copy link

broven commented Nov 19, 2018

I'll do it

@broven
Copy link

broven commented Nov 20, 2018

I have to say add a framework support to storybook is poor documented
reading the source code..

@igor-dv
Copy link
Member

igor-dv commented Nov 20, 2018

It's not documented TBH =) Mostly, people just copy an existing one and change the copy...

@trongthanh
Copy link

Hi folks, I've just opened a draft PR #5791. I've been discussing with @hoanguyen311 & @broven and we'll join effort to implement this support.

Since there's no official framework integration document, I'm still fiddling around and reading other framework examples to do this. I �will post update or raise questions under the PR issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants