Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: non-inline stories do not receive updates from controls for Docs pages #22148

Closed
quantizor opened this issue Apr 18, 2023 · 2 comments
Closed

Comments

@quantizor
Copy link

quantizor commented Apr 18, 2023

Describe the bug

There appears to be a bug where a docs page that contains a non-inline primary story does not receive arg changes from the related <Controls /> panel.

To Reproduce

Visit a Docs page for a component and set the story parameters as follows:

docs: {
  story: {
    inline: false,
  },
},

This triggers the story to load inside an iframe instead of inline. When this config is set, manipulating the controls for the story has no effect.

System

No response

Additional context

Does occur in v6 as well when inlineStories: false

@quantizor quantizor changed the title [Bug]: <Controls /> component on DocsPage does not update <Primary /> args [Bug]: non-inline stories do not receive updates from controls for Docs pages Apr 18, 2023
@quantizor
Copy link
Author

I'm wondering if it's because the ID for iframe stories has the "iframe--" prefix?

@shilman
Copy link
Member

shilman commented Apr 19, 2023

closing as dupe to #11908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants