Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Storybook manager to React 18 #20378

Closed
shilman opened this issue Dec 22, 2022 · 12 comments
Closed

Upgrade Storybook manager to React 18 #20378

shilman opened this issue Dec 22, 2022 · 12 comments
Labels
maintenance User-facing maintenance tasks ui
Milestone

Comments

@shilman
Copy link
Member

shilman commented Dec 22, 2022

Is your feature request related to a problem? Please describe

Storybook's own "manager UI" is currently using React 16, which is not the latest.

Describe the solution you'd like

We should upgrade to React 18 and do the minimum to get the UI working again.

Note that this means that addons "manager entries" will also run in React 18, so it's a breaking change that will affect our addon ecosystem.

After the upgrade we should re-enable React strict mode, reversing #20345

Also, when upgrading we should upgrade the addon API to support the most recent React 18 hooks, as described in #21034

Describe alternatives you've considered

No response

Are you able to assist to bring the feature to reality?

no

Additional context

No response

@shilman shilman added good first issue ui maintenance User-facing maintenance tasks labels Dec 22, 2022
@thebuilder
Copy link
Contributor

You should be able to revert #20345 when #20368 is merged.

@eddilou
Copy link

eddilou commented Dec 23, 2022

It would also be nice to update all dependencies.

@dohooo
Copy link

dohooo commented Dec 26, 2022

Oh, Can not wait more. 🤯

@shogohida
Copy link

Hi @shilman can I work on this?

@shilman
Copy link
Member Author

shilman commented Dec 27, 2022

@shogohida That would be amazing! 🙏 Please check out how to contribute in our docs and feel free to ask questions in #contributing in our Discord.

@shogohida
Copy link

@shilman
Thanks for your comment! I will need some help since this is the first issue of Storybook for me to deal with. I will ask questions in Discord when I need help

@macck7
Copy link

macck7 commented Jan 12, 2023

is issuse still open...
I am new here and want to work on first issuse..

@shogohida
Copy link

Hi @macck7, I'm still working on this issue even though it's taking time 🙏

@iamkelv
Copy link

iamkelv commented Jan 25, 2023

hi, @shilman , I think if the React version is to be upgraded t Ract 18 then some of the packages may also need an update else react18 may not be compatible with some older packages.

or if the issue is only focused on Upgrade then I will like to work on it.

@BradMcGonigle
Copy link

Related to #21034, is there a known workaround for using new React 18 hooks like useId in components (which we have stories for)?

I understand not being able to use the new hooks in addons but should this prevent something like useId from being used in our React 18 compatible component library?

@agriffis
Copy link
Contributor

I understand not being able to use the new hooks in addons but should this prevent something like useId from being used in our React 18 compatible component library?

This shouldn't be a problem. (I do it all the time.) I suggest opening a separate issue if it's not working for you.

@vanessayuenn
Copy link
Contributor

Closed by #24514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks ui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants