Storybook sidebar navigation: aria-expanded should be on button, not parent

[micahgodbolt]

aria-expanded is meant to be used with button, or some other role. It is currently be added to the parent div with no role making the attribute ineffective.

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-expanded#associated_roles

Moving the aria-expanded to the button that does the expanding will provide better accessibility to those using screen readers.

[micahgodbolt]

Looks like this is usually a button in the case of stories

[micahgodbolt]

Looks like the problem is right here

storybook/lib/ui/src/components/sidebar/Tree.tsx

Lines 148 to 162 in f74a04a

	<RootNode
	key={id}
	id={id}
	className="sidebar-subheading"
	data-ref-id={refId}
	data-item-id={item.id}
	data-nodetype="root"
	aria-expanded={isExpanded}
	>
	<CollapseButton
	type="button"
	data-action="collapse-root"
	onClick={(event) => {
	event.preventDefault();
	setExpanded({ ids: [item.id], value: !isExpanded });

Line 155 should be moved down to the CollapseButton

[Daraphista]

Hi, I can help out. Could you assign this issue to me?

[ajukadavid]

can i be assigned this issue?

[ghost]

hahah im not competent but for what its w0rthl haha, it might help me personally

[shilman]

Good golly!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-alpha.7 containing PR #18354 that references this issue. Upgrade today to the @future NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

[shilman]

Gadzooks!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.5.10-alpha.0 containing PR #18354 that references this issue. Upgrade today to the @prerelease NPM tag to try it out!

npx sb upgrade --prerelease

[shilman]

Son of a gun!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.5.10 containing PR #18354 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb upgrade