Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addon-storysource does not capture stories written in StoryObj (CSF v3) #17975

Open
lacolaco opened this issue Apr 15, 2022 · 2 comments
Open

Comments

@lacolaco
Copy link

Describe the bug

addon-storysource does not capture the information of stories written in CSF v3.

To Reproduce
Please create a reproduction by running npx sb@next repro and following the instructions. Read our documentation to learn more about creating reproductions.
Paste your repository and deployed reproduction here. We prioritize issues with reproductions over those without.

Repro is not created yet.

System
Please paste the results of npx sb@next info here.

Environment Info:

  System:
    OS: macOS 11.6.4
    CPU: (8) x64 Intel(R) Core(TM) i7-8569U CPU @ 2.80GHz
  Binaries:
    Node: 14.19.0 - ~/.nodebrew/current/bin/node
    Yarn: 1.22.15 - ~/.nodebrew/current/bin/yarn
    npm: 7.14.0 - ~/Works/xxxx/node_modules/.bin/npm
  npmPackages:
    @storybook/addon-essentials: 6.4.21 => 6.4.21 
    @storybook/addon-interactions: 6.4.21 => 6.4.21 
    @storybook/addon-storysource: 6.4.21 => 6.4.21 
    @storybook/addons: 6.4.21 => 6.4.21 
    @storybook/angular: 6.4.21 => 6.4.21 
    @storybook/builder-webpack5: 6.4.21 => 6.4.21 
    @storybook/cli: 6.4.21 => 6.4.21 
    @storybook/jest: 0.0.10 => 0.0.10 
    @storybook/manager-webpack5: 6.4.21 => 6.4.21 
    @storybook/preset-scss: 1.0.3 => 1.0.3 
    @storybook/testing-library: 0.0.9 => 0.0.9 

Additional context
Add any other context about the problem here.

@lacolaco lacolaco changed the title addon-storysource does not capture stories from StoryObj (CSF v3) addon-storysource does not capture stories written in StoryObj (CSF v3) Apr 15, 2022
@daneah
Copy link

daneah commented Nov 4, 2022

This still appears to be the case in 6.5.9.

More broadly, I have seen @shilman suggest not using addon-storysource and the addon is not mentioned in a first-class way in the official docs. I'm curious if there's a sentiment that we should forego it in favor of doc blocks (which do work great with CSF 3)?

@shilman
Copy link
Member

shilman commented Nov 7, 2022

@daneah FWIW I recently updated doc blocks to use a csf-plugin #19680, which will allow us to move both source-loader and addon-storysource out of the monorepo. I'm hoping to also create an addon based on the same underlying code as doc blocks that shows up next to your story in the addon panel, but don't have a timeline for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants