Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storyName property in CSF3 objects with storyStoreV7 enabled doesn't work #17548

Closed
Guria opened this issue Feb 22, 2022 · 3 comments
Closed

Comments

@Guria
Copy link
Contributor

Guria commented Feb 22, 2022

Describe the bug
With storyStoreV7 feature enabled overriding story name with storyName property in CSF3 format doesn't works.
image

To Reproduce

  • npx sb@next repro
    • react
    • cra_typescript
  • add features: { storyStoreV7: true, }, to .storybook/main.js
  • edit src/stories/Button.stories.tsx to rewrite using CSF3 format
export const Primary: ComponentStoryObj<typeof Button> = {
  args: {
    primary: true,
    label: 'Button',
  },
  storyName: "Override using storyName"
};

export const Secondary: ComponentStoryObj<typeof Button> = {
  args: {
    label: 'Button',
  },
  name: "Override using name"
};

System

Environment Info:

  System:
    OS: Linux 5.13 Ubuntu 21.10 21.10 (Impish Indri)
    CPU: (8) x64 Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz
  Binaries:
    Node: 14.18.1 - ~/.volta/tools/image/node/14.18.1/bin/node
    Yarn: 1.22.15 - ~/.volta/tools/image/yarn/1.22.15/bin/yarn
    npm: 8.5.0 - ~/.volta/tools/image/npm/8.5.0/bin/npm
  Browsers:
    Chrome: 98.0.4758.102
    Firefox: 97.0

Additional context
Initially reported at storybookjs/builder-vite#253
Most suspicious code found during debug:
https://github.com/storybookjs/storybook/blob/main/lib/store/src/normalizeStory.ts#L47-L51

@shilman
Copy link
Member

shilman commented Jun 12, 2022

Yippee!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.5.9-alpha.0 containing PR #18464 that references this issue. Upgrade today to the @prerelease NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman
Copy link
Member

shilman commented Jun 13, 2022

Yowza!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.5.9 containing PR #18464 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb upgrade

@shilman
Copy link
Member

shilman commented Jun 15, 2022

Zoinks!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-alpha.2 containing PR #18464 that references this issue. Upgrade today to the @future NPM tag to try it out!

npx sb upgrade --prerelease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants