Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide menu toggle and toggle panel when toggling fullscreen in singleStory mode #15553

Closed
ghengeveld opened this issue Jul 12, 2021 · 8 comments
Closed
Assignees
Labels
Milestone

Comments

@ghengeveld
Copy link
Member

When using singleStory=true (query param), there should be no way to bring up the sidebar. Currently there's two icons to toggle it:

Screenshot 2021-07-12 at 13 52 47

The menu toggle should be hidden in singleStory mode. The fullscreen toggle should toggle the addon panel if there are any, or not be displayed either.

@domyen
Copy link
Member

domyen commented Jul 12, 2021

Related UX changes for the toolbar + sidebar + addon panel toggles here

@alk-mandrianarijaona
Copy link

hey, I can take this one

@shilman
Copy link
Member

shilman commented Aug 4, 2021

@alk-mandrianarijaona Thank you for helping make Storybook better! 🙏 Please check out how to contribute in our docs and feel free to ask questions in #contributing in our Discord.

@alk-mandrianarijaona
Copy link

alk-mandrianarijaona commented Aug 4, 2021

The fullscreen toggle should toggle the addon panel if there are any, or not be displayed either.

@shilman @domyen @ghengeveld can you guys tell me what's the way to check if there is an addon panel to display?

@alk-mandrianarijaona
Copy link

alk-mandrianarijaona commented Aug 4, 2021

The fullscreen toggle should toggle the addon panel if there are any, or not be displayed either.

@shilman @domyen @ghengeveld can you guys tell me what's the way to check if there is an addon panel to display?

OK I just found it, I need to check showPanel

edit: hmm I think I am wrong here

@ghengeveld
Copy link
Member Author

See

const panelCount = Object.keys(api.getPanels()).length;

@shilman
Copy link
Member

shilman commented Nov 2, 2021

Ta-da!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.0-beta.24 containing PR #15755 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Nov 2, 2021
@shilman
Copy link
Member

shilman commented Nov 2, 2021

Jeepers creepers!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.0-beta.25 containing PR #15755 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants