Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y addon: Reverse the label and description content in the Accordion #15445

Closed
MichaelArestad opened this issue Jun 30, 2021 · 6 comments
Closed

Comments

@MichaelArestad
Copy link
Contributor

MichaelArestad commented Jun 30, 2021

Problem

  1. The most clear and concise description of an A11y test is hidden until the accordion is open.
  2. Many, if not all, of the current labels in the AccordionHeader start with "Ensures" making it more difficult to scan and is slightly confusing.

Proposal

I believe both the AccordionHeader content and the description content are provided via an API so I don't want to edit the copy. Instead, I propose we swap where each bit of copy is located. You can see my proposal in the above image.

A11y - labels

Are you able to assist to bring the feature to reality?
Yep!

┆Issue is synchronized with this Asana task by Unito

@harshsingh941
Copy link

I like to work on this project .So can i start ??

@MichaelArestad
Copy link
Contributor Author

@harshsingh941 Please! I will be happy to review.

@amartinez62 amartinez62 added this to the Design milestone Jul 1, 2021
@harshsingh941
Copy link

I am working on this for the first time . So I am not able to locate where this labels are in the code can you help me?

@MichaelArestad
Copy link
Contributor Author

@harshsingh941 I'm sorry for the slow response. There is a PR open that you can look at to see where the labels are: #15466

@MichaelArestad
Copy link
Contributor Author

Fixed in #15466

@shilman
Copy link
Member

shilman commented Jul 2, 2021

Jiminy cricket!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.0-alpha.11 containing PR #15466 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants