New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matching to color control not working #15443
Comments
This must be some kind of regression, I had a color picker, now without any changes, its plain text field. Adding a proper HEX color works as expected, just not the color picker. |
Possible duplicate to #15446 |
Can you please create a reproduction by running |
I have created a reproduction of this issue using |
Thank you so much for the repro! I'll get onto it soon |
Whoopee!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.0-alpha.15 containing PR #15549 that references this issue. Upgrade today to the
Closing this issue. Please re-open if you think there's still more to do. |
Jeepers creepers!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.3.5 containing PR #15549 that references this issue. Upgrade today to the
|
Describe the bug
we declared a matcher for color control in preview.js. And even though we declared '(string | undefined)' type 'backgroundColor' prop, the color matcher is not working. It seems that the its type is defined as undefined with "Addon controls: Control of type only supported string, received "undefined" message in console. The default value of 'backgroundColor' prop was specified, but the same bug also occurred.
To Reproduce
A simple example.
button.tsx
button.stories.tsx
preview.js
System
Environment Info:
System:
OS: Windows 10 10.0.19042
CPU: (8) x64 Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz
Binaries:
Node: 15.14.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.5 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 7.7.6 - C:\Program Files\nodejs\npm.CMD
Browsers:
Edge: Spartan (44.19041.1023.0), Chromium (91.0.864.59)
npmPackages:
@storybook/addon-a11y: ^6.3.1 => 6.3.1
@storybook/addon-actions: ^6.3.1 => 6.3.1
@storybook/addon-essentials: ^6.3.1 => 6.3.1
@storybook/addon-links: ^6.3.1 => 6.3.1
@storybook/addon-storysource: ^6.3.1 => 6.3.1
@storybook/react: ^6.3.1 => 6.3.1
┆Issue is synchronized with this Asana task by Unito
The text was updated successfully, but these errors were encountered: