Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbars config regression: should fall back to name when no title is present #15259

Closed
kaelig opened this issue Jun 16, 2021 · 3 comments
Closed

Toolbars config regression: should fall back to name when no title is present #15259

kaelig opened this issue Jun 16, 2021 · 3 comments
Assignees
@yannbf
Labels
addon: toolbars bug help wanted

Comments

@kaelig
Copy link
Contributor

kaelig commented Jun 16, 2021 •
edited by sync-by-unito bot

Describe the bug

I noticed that in recent pre-releases of 6.3, toolbars we defined in globalTypes stopped appearing unless they had an icon.

I'd expect toolbars without a title (new key in 6.3) to still appear, and to see a console deprecation message telling me to specify the title.

(Regression confirmed with @shilman)
@shilman shilman added this to the 6.3 blockers milestone Jun 16, 2021
@shilman shilman added the tiny label Jul 6, 2021
@huyenltnguyen huyenltnguyen mentioned this issue Feb 6, 2022
Merged
3 tasks
@yannbf yannbf self-assigned this Feb 7, 2022
@shilman shilman removed this from the 6.4 improvements milestone May 20, 2022
@shilman
Copy link
Member

shilman commented Jul 25, 2022

Ermahgerd!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-alpha.16 containing PR #17430 that references this issue. Upgrade today to the @future NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Jul 25, 2022
@shilman
Copy link
Member

shilman commented Jul 26, 2022

w00t!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.5.10-alpha.0 containing PR #17430 that references this issue. Upgrade today to the @prerelease NPM tag to try it out!

npx sb upgrade --prerelease

@shilman
Copy link
Member

shilman commented Aug 4, 2022

Ta-da!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.5.10 containing PR #17430 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yannbf yannbf

Labels
addon: toolbars bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kaelig @shilman @yannbf