Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic preview head not rendering #14496

Closed
stuartizon-x opened this issue Apr 7, 2021 · 4 comments
Closed

Dynamic preview head not rendering #14496

stuartizon-x opened this issue Apr 7, 2021 · 4 comments
Assignees

Comments

@stuartizon-x
Copy link

stuartizon-x commented Apr 7, 2021

Not sure if I've misunderstood this feature, but I've tried to add the new previewHead config option (#13432) and it seems to not be doing anything.

I've created a small sample repo here based on the way it's described in the docs. https://github.com/stuartizon-x/storybook-example.

I'd expect to see the yellow background I've added to the previewHead, or at least the added preview markup inside the DOM.

┆Issue is synchronized with this Asana task by Unito

@shilman
Copy link
Member

shilman commented Apr 7, 2021

Turns out the presets got renamed to xTemplate (e.g. previewHeadTemplate) in commit 2a5895c

I tested out previewHeadTemplate in your repro and it's working as expected.

I'll discuss the change with @ndelangen to see whether we need to update the documentation or revert the changes. Thanks for raising the issue & sorry for the confusion!

@stuartizon-x
Copy link
Author

Ah good to know I'm not a complete idiot! Thanks

@shilman
Copy link
Member

shilman commented Apr 7, 2021

ZOMG!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.2.5 containing PR #14500 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb upgrade

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Apr 7, 2021
@stuartizon-x
Copy link
Author

Amazing. Thanks for your prompt support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants