Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apostrophes rendered incorrectly #14116

Closed
dexster opened this issue Mar 3, 2021 · 1 comment
Closed

Apostrophes rendered incorrectly #14116

dexster opened this issue Mar 3, 2021 · 1 comment

Comments

@dexster
Copy link
Contributor

dexster commented Mar 3, 2021

Comments generated by compodocs are not translated back to apostrophes in Storybook

To Reproduce

Use a default angular storybook build and add this comment to any of your button component inputs:
/** element's */

Viewing the control in the canvas or docs tab shows
Screenshot 2021-03-03 at 22 40 20

Expected behavior
Apostrophes should show correctly

System
System:
OS: macOS 11.2.2
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Binaries:
Node: 14.15.5 - ~/.nvm/versions/node/v14.15.5/bin/node
Yarn: 1.22.5 - ~/.nvm/versions/node/v14.15.5/bin/yarn
npm: 6.14.11 - ~/.nvm/versions/node/v14.15.5/bin/npm
Browsers:
Chrome: 88.0.4324.192
Edge: 88.0.705.81
Firefox: 86.0
Safari: 14.0.3
npmPackages:
@storybook/addon-actions: ^6.1.20 => 6.1.20
@storybook/addon-essentials: ^6.1.20 => 6.1.20
@storybook/addon-links: ^6.1.20 => 6.1.20
@storybook/angular: ^6.1.20 => 6.1.20

@shilman
Copy link
Member

shilman commented Aug 7, 2021

w00t!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.0-alpha.25 containing PR #15774 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants