npx sb extract not working as expected #13561

Niznikr · 2021-01-05T16:07:11Z

Describe the bug
Running npx sb extract results in the following error:

npx sb extract
info connecting to: http://localhost:57011/iframe.html
info installing puppeteer...
TimeoutError: waiting for function failed: timeout 30000ms exceeded
    at new WaitTask (/Users/rniznik/.npm/_npx/37097/lib/node_modules/sb/node_modules/puppeteer-core/lib/DOMWorld.js:549:28)
    at DOMWorld.waitForFunction (/Users/rniznik/.npm/_npx/37097/lib/node_modules/sb/node_modules/puppeteer-core/lib/DOMWorld.js:454:12)
    at Frame.waitForFunction (/Users/rniznik/.npm/_npx/37097/lib/node_modules/sb/node_modules/puppeteer-core/lib/FrameManager.js:657:28)
    at Page.waitForFunction (/Users/rniznik/.npm/_npx/37097/lib/node_modules/sb/node_modules/puppeteer-core/lib/Page.js:1141:29)
    at read (/Users/rniznik/.npm/_npx/37097/lib/node_modules/sb/node_modules/@storybook/cli/dist/extract.js:30:14)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async extract (/Users/rniznik/.npm/_npx/37097/lib/node_modules/sb/node_modules/@storybook/cli/dist/extract.js:87:18)

To Reproduce
Steps to reproduce the behavior:

Go to a Storybook project
Run npx sb extract from the terminal

Expected behavior
The command runs and creates a stories.json file.

Environment Info:

  System:
    OS: macOS 10.15.7
    CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
  Binaries:
    Node: 14.15.1 - ~/.nvm/versions/node/v14.15.1/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.8 - ~/.nvm/versions/node/v14.15.1/bin/npm
  Browsers:
    Chrome: 87.0.4280.88
    Edge: 87.0.664.66
    Firefox: 84.0.1
    Safari: 14.0.2
  npmPackages:
    @storybook/addon-a11y: ^6.1.11 => 6.1.11 
    @storybook/addon-actions: ^6.1.11 => 6.1.11 
    @storybook/addon-controls: ^6.1.11 => 6.1.11 
    @storybook/addon-docs: ^6.1.11 => 6.1.11 
    @storybook/addon-storysource: ^6.1.11 => 6.1.11 
    @storybook/addon-viewport: ^6.1.11 => 6.1.11 
    @storybook/addons: ^6.1.11 => 6.1.11 
    @storybook/react: ^6.1.11 => 6.1.11 
    @storybook/source-loader: ^6.1.11 => 6.1.11 
    @storybook/theming: ^6.1.11 => 6.1.11 
    @storybook/web-components: ^6.1.11 => 6.1.11

Additional context
Add any other context about the problem here.

The text was updated successfully, but these errors were encountered:

diegofss11 · 2021-02-16T03:29:21Z

Did it work yet?

Niznikr · 2021-02-18T13:21:20Z

Nope still failing.

shilman · 2021-02-18T14:32:52Z

Perhaps you can install puppeteer manually by hand to avoid hitting this timeout? It's slow to install. @ndelangen WDYT?

Niznikr · 2021-02-18T15:05:57Z

Still times out even after manual install.

cy6erskunk · 2021-03-09T13:35:31Z

The same issue here... It seems that there's no way to use pre-intalled puppeteer if understood #13724 correctly.

NiklasPor · 2021-03-12T13:23:24Z

Ran into the same issue. Strangely I resolved it by calling sb extract from the root of the repository with the dist folder as a parameter:

npx sb extract dist/storybook/your-lib/

This strangely worked in opposite to cd dist/storybook/your-lib/ && sb extract in my case.

pjoulot · 2021-07-22T18:25:31Z

Same issue here.
Installing the package manually seems to not work for me.

mtsmachado8 · 2021-08-10T02:04:54Z

Same issue here... It's a really bad bug because i cannot use storybook composeable feature.

shilman · 2021-08-10T12:15:19Z

There is an experimental built-in stories.json generation. Here's how to use it:

Upgrade 6.4-alpha (npx sb upgrade --prerelease)
Only works on CSF & MDX stories (no storiesOf)
Set the following experimental flag in your .storybook/main.js config:

module.exports = {
  features: {
    buildStoriesJson: true,
  }
};

Then when you yarn build-storybook it should also generate stories.json in the output folder. This stories.json is not exactly the same format as what comes out of sb extract, but it seems to work pretty well already even though it's experimental. It will become the default in 6.4.

ndelangen · 2021-10-28T07:42:23Z

Taking a look at this today

ndelangen · 2021-10-28T09:31:39Z

@tmeasday I'm hitting this line:

storybook/lib/store/src/StoryStore.ts

Line 297 in 0a5466a

    
           throw new Error('Cannot call extract() unless you call cacheAllCSFFiles() first.');

can you fill me in on the background info in this?

tmeasday · 2021-10-28T10:41:00Z

@ndelangen in order to call extract() you need to initialize and pre-cache the store.

In v6 mode that happens automatically and syncronously, so it shouldn't be an issue.

In v7 mode, you need to await preview.cacheAllCSFFiles() before calling functions like store.getStoriesJson(). So we would need to do that in the extract script.

There isn't really any reason to call extract in v7 mode, seeing as a build will generate (the same) stories.json anyway. But I guess we should fix it nonetheless.

shilman · 2021-11-04T10:42:53Z

ZOMG!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.0-beta.27 containing PR #16505 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

itwasmattgregg · 2022-01-27T22:20:15Z

I'm on v6.4.13 and am getting this error. I'm not opted in to v7 store mode.

itwasmattgregg · 2022-01-28T14:28:29Z

Coming back to this: I figured out I was starting to use auto generated titles. For some reason removing the explicit titles on stories caused this error to fire on our custom a11y test function which currently uses extract.

tmeasday · 2022-01-31T02:51:32Z

@itwasmattgregg I will be looking at a fix to this soon.

stabback · 2022-02-08T19:59:05Z

Regarding this: #13561 (comment)

I ran into this error on 6.4.18 on the v6 store @tmeasday. We are using a mix of modern CSF and legacy storiesOf in our codebase. I'm wondering if the storiesOf syntax is confusing things.

I had to downgrade back to 6.3.x to avoid this issue.

tmeasday · 2022-02-08T20:39:00Z

@stabback -- you are hitting the line "Cannot call extract() unless you call cacheAllCSFFiles() first." on the v6 store? That's surprising -- do you have a reproduction you can share?

stabback · 2022-02-08T20:51:33Z

Unfortunately, I do not have a reproduction I can share :(. I was commenting hoping the additional context of the mix of CSF and storiesOf could help explain some of the discrepancies. I can reliably cause this error by updating from 6.3 to 6.4, with no other change to my code.

tmeasday · 2022-02-08T22:59:45Z

@stabback can you share your main.js and preview.js?

stabback · 2022-02-09T16:21:44Z

@tmeasday Happy to continue this off the public GitHub issue, however let's be sure to post the findings back here once resolved.

shilman · 2022-02-11T05:13:03Z

Ermahgerd!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.5.0-alpha.39 containing PR #17447 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

shilman · 2022-02-12T10:13:52Z

Jiminy cricket!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.19 containing PR #17447 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb upgrade

ritz078 · 2023-07-22T17:21:23Z

I am on 7.1.0 and I am still facing this issue.

HashemKhalifa · 2023-09-15T12:54:30Z

I'm on 7.4.1 and still facing the same issue!!

HashemKhalifa · 2023-09-15T13:05:31Z

the way to solve this issue is to override puppeteer-core in the package.json with version 13.7.0

I'm using pnpm so it will be


  "pnpm": {
    "overrides": {
      "puppeteer-core": "^13.7.0",
    }
  },

you can use resolutions in case of yarn, npm

shilman added bug cli P1 labels Feb 18, 2021

shilman added the has workaround label Mar 12, 2021

shilman added the composition label Aug 10, 2021

ndelangen self-assigned this Oct 28, 2021

ndelangen mentioned this issue Oct 28, 2021

CLI: Add a check for source-dir in sb extract #16505

Merged

shilman closed this as completed Nov 4, 2021

tmeasday mentioned this issue Feb 9, 2022

Core/CLI: Add extract function to PreviewWeb and use it in sb extract if available #17447

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

npx sb extract not working as expected #13561

npx sb extract not working as expected #13561

Niznikr commented Jan 5, 2021

diegofss11 commented Feb 16, 2021

Niznikr commented Feb 18, 2021

shilman commented Feb 18, 2021

Niznikr commented Feb 18, 2021

cy6erskunk commented Mar 9, 2021

NiklasPor commented Mar 12, 2021

pjoulot commented Jul 22, 2021

mtsmachado8 commented Aug 10, 2021

shilman commented Aug 10, 2021 •

edited

ndelangen commented Oct 28, 2021

ndelangen commented Oct 28, 2021

tmeasday commented Oct 28, 2021 •

edited

shilman commented Nov 4, 2021

itwasmattgregg commented Jan 27, 2022

itwasmattgregg commented Jan 28, 2022

tmeasday commented Jan 31, 2022 •

edited

stabback commented Feb 8, 2022 •

edited

tmeasday commented Feb 8, 2022

stabback commented Feb 8, 2022

tmeasday commented Feb 8, 2022

stabback commented Feb 9, 2022

shilman commented Feb 11, 2022

shilman commented Feb 12, 2022

ritz078 commented Jul 22, 2023

HashemKhalifa commented Sep 15, 2023

HashemKhalifa commented Sep 15, 2023

npx sb extract not working as expected #13561

npx sb extract not working as expected #13561

Comments

Niznikr commented Jan 5, 2021

diegofss11 commented Feb 16, 2021

Niznikr commented Feb 18, 2021

shilman commented Feb 18, 2021

Niznikr commented Feb 18, 2021

cy6erskunk commented Mar 9, 2021

NiklasPor commented Mar 12, 2021

pjoulot commented Jul 22, 2021

mtsmachado8 commented Aug 10, 2021

shilman commented Aug 10, 2021 • edited

ndelangen commented Oct 28, 2021

ndelangen commented Oct 28, 2021

tmeasday commented Oct 28, 2021 • edited

shilman commented Nov 4, 2021

itwasmattgregg commented Jan 27, 2022

itwasmattgregg commented Jan 28, 2022

tmeasday commented Jan 31, 2022 • edited

stabback commented Feb 8, 2022 • edited

tmeasday commented Feb 8, 2022

stabback commented Feb 8, 2022

tmeasday commented Feb 8, 2022

stabback commented Feb 9, 2022

shilman commented Feb 11, 2022

shilman commented Feb 12, 2022

ritz078 commented Jul 22, 2023

HashemKhalifa commented Sep 15, 2023

HashemKhalifa commented Sep 15, 2023

shilman commented Aug 10, 2021 •

edited

tmeasday commented Oct 28, 2021 •

edited

tmeasday commented Jan 31, 2022 •

edited

stabback commented Feb 8, 2022 •

edited