Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npx sb upgrade incorrectly Warns about "outdated packages" for @storybook/storybook-deployer #13305

Closed
haysclark opened this issue Nov 26, 2020 · 1 comment

Comments

@haysclark
Copy link

Describe the bug
Running npx sb upgrade in a project with the latest version of @storybook/storybook-deployer will result in an incorrect warning that the package is outdated.

To Reproduce
Steps to reproduce the behavior:

  1. Have a project with Storybook as NPM dependency:
{
  "devDependencies": {
    "@storybook/addon-actions": "^6.0.0",
    "@storybook/addon-essentials": "^6.0.0",
    "@storybook/addon-links": "^6.0.0",
    "@storybook/react": "^6.0.0",
    "@storybook/storybook-deployer": "^2.8.7"
  }
}
  1. Run npx sb upgrade
  2. See CLI error
npx sb upgrade
...
WARN Found 1 outdated packages (relative to '@storybook/core-events@6.1.7')
WARN Please make sure your packages are updated to ensure a consistent experience.
WARN - @storybook/storybook-deployer@2.8.7

Expected behavior
If the latest version of @storybook/storybook-deployer is installed, the upgrade command should not warn the user.

System

Environment Info:

  System:
    OS: macOS High Sierra 10.13.6
    CPU: (8) x64 Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz
  Binaries:
    Node: 10.22.0 - ~/.nvm/versions/node/v10.22.0/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.6 - ~/.nvm/versions/node/v10.22.0/bin/npm
  Browsers:
    Chrome: 87.0.4280.67
    Firefox: 63.0.3
    Safari: 13.1.2
  npmPackages:
    @storybook/addon-actions: ^6.1.7 => 6.1.7 
    @storybook/addon-essentials: ^6.1.7 => 6.1.7 
    @storybook/addon-links: ^6.1.7 => 6.1.7 
    @storybook/react: ^6.1.7 => 6.1.7 
    @storybook/storybook-deployer: ^2.8.7 => 2.8.7 
@shilman
Copy link
Member

shilman commented Nov 27, 2020

Jeepers creepers!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.1.8 containing PR #13306 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb upgrade

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants