Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash is being removed from iframe URL #13273

Closed
Hypnosphi opened this issue Nov 25, 2020 · 6 comments
Closed

Hash is being removed from iframe URL #13273

Hypnosphi opened this issue Nov 25, 2020 · 6 comments
Assignees
Milestone

Comments

@Hypnosphi
Copy link
Member

Hypnosphi commented Nov 25, 2020

It's a regression introduced in 6.1

see #11677 (comment)

Open https://next--storybookjs.netlify.app/official-storybook/iframe.html?id=addons-docs-buttongroup--basic&viewMode=story#anchor

Hash should remain there

@tmeasday
Copy link
Member

@Hypnosphi are you sure this wasn't in 6.0?

@shilman shilman added this to the 6.1.x milestone Nov 25, 2020
@shilman shilman added the P0 label Nov 25, 2020
@Hypnosphi
Copy link
Member Author

Maybe it was, but for some reason it didn't manifest itself in our case cc @andrey-skl

@andrey-skl
Copy link

Sorry everybody for misleading. I checked again and found that:

Yes, the hash was stripping in 6.0 (6.0.28). But it did not affect our case because it was stripped a little bit after sroty initialization.

For example, if I open http://localhost:9999/iframe.html?id=components-button--basic#test with storybook@6.0.28 and log window.location in the first line of the story, it is: http://localhost:9999/iframe.html?id=components-button--basic#test

With 6.1.0-rc.0 it logs: http://localhost:9999/iframe.html?id=components-button--basic&viewMode=story

@shilman shilman removed their assignment Nov 26, 2020
@tmeasday
Copy link
Member

tmeasday commented Nov 27, 2020

Ahh, ok. My guess is the difference is the new loaders feature which adds an await into the story render process (awaiting nothing usually), which probably rearranges the execution of some code.

@shilman
Copy link
Member

shilman commented Nov 27, 2020

Huzzah!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.1.8 containing PR #13308 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb upgrade

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Nov 27, 2020
@andrey-skl
Copy link

@shilman @Hypnosphi thanks a lot for a quick fix, our case works perfect so far!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants