New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line height in Typeset component is broken #12786
Comments
@shilman @coderitual I cannot reproduce this. My code:
@coderitual Are you specifying |
@jpzwarte in css I also think that setting It would be awesome to have |
@coderitual Setting A "workaround" for your problem would be to specify a valid Feel free to submit a PR that allows you to customize the |
thanks @jpzwarte :) |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Can we reactivate this? |
Looking forward to this update. |
Describe the bug
Line height in
Typeset
component is broken.Typeset
component should allow to providelineHeights
prop which will be corresponding tofontSizes
prop. That way we can create proper presentation of font (we always need to define lineHeight to get the best look from the font for a given fontSizes)Currently it is set based on size, but there is a bug (no
px
suffix so the unit is relative by default - forfontSize
, number ispx
by default).Previously its value was fixed to
1
.926b68f
Expected behavior
Exposed
lineHeights
prop inTypeset
componentScreenshots
Code snippets
926b68f
The text was updated successfully, but these errors were encountered: