Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If built with wrong configuration, the story frame turns recursive #10143

Closed
prashnts opened this issue Mar 17, 2020 · 2 comments
Closed

If built with wrong configuration, the story frame turns recursive #10143

prashnts opened this issue Mar 17, 2020 · 2 comments

Comments

@prashnts
Copy link

Describe the bug

It's not particularly a bug, rather an interesting/concerning side effect.

My storybook configuration is out of date, but it is correct, and the static export of Storybook completes without errors. However the "story" iframe errors with a 404. Netlify substitute it with their 404 page, with a link to ´/´. Clicking this repeats.

79653527-7134-48DC-AB4E-B3A8BDAB970A
6E0E3D05-72AE-427C-B6B1-C2A596C6DF60

Here's a screenshot. Of course its not particularly a bug, and please close it if you think the same. But concerns, that i haven't checked, are:

  • can this iFrame load whatever website if there's a link?
  • if so, is that somehow a security problem?
  • would it be useful to handle the 404 in the root page? (i can send a pull request)

Link to the page: https://deploy-preview-149--welearn-dev.netlify.com
Config: (outdated) https://github.com/CyberCRI/learn-ext/blob/36b1ec9f1d3224d1118caf6d7a4107b9a9ad500f/.storybook/config.js

@stale
Copy link

stale bot commented Apr 7, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Apr 7, 2020
@shilman
Copy link
Member

shilman commented Apr 7, 2020

Thanks! Closing as dupe to #5269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants