From 056e20ad7544ddef208e87d5f249ca1a1803d66c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9sar=20Souza=20Liedke?= Date: Fri, 25 Sep 2020 15:12:37 -0300 Subject: [PATCH 1/3] Refactored page title splitting and space insertion --- lib/ui/src/containers/preview.tsx | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/lib/ui/src/containers/preview.tsx b/lib/ui/src/containers/preview.tsx index 6d692f0758d7..48abeda7a4b0 100644 --- a/lib/ui/src/containers/preview.tsx +++ b/lib/ui/src/containers/preview.tsx @@ -7,12 +7,7 @@ import { Preview } from '../components/preview/preview'; export type Item = StoriesHash[keyof StoriesHash]; -const nonAlphanumSpace = /[^a-z0-9 ]/gi; -const doubleSpace = /\s\s/gi; -const replacer = (match: string) => ` ${match} `; - -const addExtraWhiteSpace = (input: string) => - input.replace(nonAlphanumSpace, replacer).replace(doubleSpace, ' '); +const splitTitleAddExtraSpace = (input: string) => input.split('/').join(' / '); const getDescription = (item: Item) => { if (isRoot(item)) { @@ -23,7 +18,7 @@ const getDescription = (item: Item) => { } if (isStory(item)) { const { kind, name } = item; - return kind && name ? addExtraWhiteSpace(`${kind} - ${name} ⋅ Storybook`) : 'Storybook'; + return kind && name ? splitTitleAddExtraSpace(`${kind} - ${name} ⋅ Storybook`) : 'Storybook'; } return 'Storybook'; From fc3549b1a7a8af5c7857e3e5f7c9052134a990b6 Mon Sep 17 00:00:00 2001 From: Michael Shilman Date: Sat, 26 Sep 2020 09:44:19 +0800 Subject: [PATCH 2/3] Title splitting test case --- examples/official-storybook/stories/core/unicode.stories.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/official-storybook/stories/core/unicode.stories.js b/examples/official-storybook/stories/core/unicode.stories.js index 5da6025bd806..e85392f4a872 100644 --- a/examples/official-storybook/stories/core/unicode.stories.js +++ b/examples/official-storybook/stories/core/unicode.stories.js @@ -5,3 +5,5 @@ storiesOf('Core/Unicode', module) .add('😀', () =>

❤️

) .add('Кнопки', () =>

нормальный

) .add('바보', () =>

🤷🏻‍♂️

); + +storiesOf('Core/Unicode/Primário', module).add('😀', () =>

❤️

); From 27303294a33923824fd9ba368dd916f16af6c5d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9sar=20Souza=20Liedke?= Date: Mon, 28 Sep 2020 09:10:41 -0300 Subject: [PATCH 3/3] add double white space replacing --- lib/ui/src/containers/preview.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ui/src/containers/preview.tsx b/lib/ui/src/containers/preview.tsx index 48abeda7a4b0..84d10242aeb0 100644 --- a/lib/ui/src/containers/preview.tsx +++ b/lib/ui/src/containers/preview.tsx @@ -7,7 +7,7 @@ import { Preview } from '../components/preview/preview'; export type Item = StoriesHash[keyof StoriesHash]; -const splitTitleAddExtraSpace = (input: string) => input.split('/').join(' / '); +const splitTitleAddExtraSpace = (input: string) => input.split('/').join(' / ').replace(/\s\s/, ' '); const getDescription = (item: Item) => { if (isRoot(item)) {