From d7eb4b91d0195e582e1dd8cdabd26b6ca16598a9 Mon Sep 17 00:00:00 2001 From: Albert Darmawan Date: Wed, 16 Oct 2019 21:59:02 +0700 Subject: [PATCH 1/4] fix(Addon Docs): Fix Props block rendering issue on forwardedRef --- addons/docs/src/blocks/Props.tsx | 6 ++++-- .../stories/addon-docs/forward-ref.stories.js | 12 ++++++++++++ 2 files changed, 16 insertions(+), 2 deletions(-) create mode 100644 examples/official-storybook/stories/addon-docs/forward-ref.stories.js diff --git a/addons/docs/src/blocks/Props.tsx b/addons/docs/src/blocks/Props.tsx index ab4769476adf..a666e4249c98 100644 --- a/addons/docs/src/blocks/Props.tsx +++ b/addons/docs/src/blocks/Props.tsx @@ -27,11 +27,13 @@ export const getPropsTableProps = ( const params = parameters || {}; const { component, framework = null } = params; - const target = of === CURRENT_SELECTION ? component : of; + let target = of === CURRENT_SELECTION ? component : of; if (!target) { throw new Error(PropsTableError.NO_COMPONENT); } - + if (target.render) { + target = target.render().type; + } const { getPropDefs = inferPropDefs(framework) } = params.docs || {}; if (!getPropDefs) { throw new Error(PropsTableError.PROPS_UNSUPPORTED); diff --git a/examples/official-storybook/stories/addon-docs/forward-ref.stories.js b/examples/official-storybook/stories/addon-docs/forward-ref.stories.js new file mode 100644 index 000000000000..aa4d994c1278 --- /dev/null +++ b/examples/official-storybook/stories/addon-docs/forward-ref.stories.js @@ -0,0 +1,12 @@ +import React from 'react'; +import { Button } from '@storybook/react/demo'; + +const ForwardedButton = React.forwardRef((props, ref) =>