From 4751e497aa4c3f4951c0c6018a3527f54cca4aad Mon Sep 17 00:00:00 2001 From: dhuang612 Date: Sun, 13 Oct 2019 18:46:11 -0400 Subject: [PATCH] enabled display error details feature --- lib/core/src/server/build-static.js | 9 ++++++++- lib/core/src/server/cli/dev.js | 1 + lib/core/src/server/manager/manager-webpack.config.js | 3 --- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/core/src/server/build-static.js b/lib/core/src/server/build-static.js index 90990f2c2ec0..37c1f7c1743a 100644 --- a/lib/core/src/server/build-static.js +++ b/lib/core/src/server/build-static.js @@ -130,12 +130,15 @@ async function buildManager(configType, outputDir, configDir, options) { if (options.debugWebpack) { logConfig('Manager webpack config', managerConfig); } + if (options.stats.errorDetails) { + logConfig('Manager webpack config', managerConfig); + } return compileManager(managerConfig, managerStartTime); } async function buildPreview(configType, outputDir, packageJson, options) { - const { watch, debugWebpack } = options; + const { watch, debugWebpack, errorDetails } = options; logger.info('=> Building preview..'); const previewStartTime = process.hrtime(); @@ -150,6 +153,10 @@ async function buildPreview(configType, outputDir, packageJson, options) { ...options, }); + if (errorDetails) { + logConfig('Show verbose errors', previewConfig); + } + if (debugWebpack) { logConfig('Preview webpack config', previewConfig); } diff --git a/lib/core/src/server/cli/dev.js b/lib/core/src/server/cli/dev.js index 8bf7f4c91025..76cbb1154022 100644 --- a/lib/core/src/server/cli/dev.js +++ b/lib/core/src/server/cli/dev.js @@ -29,6 +29,7 @@ async function getCLI(packageJson) { .option('--quiet', 'Suppress verbose build output') .option('--no-dll', 'Do not use dll reference') .option('--debug-webpack', 'Display final webpack configurations for debugging purposes') + .option('--display-error-details', 'Show errors') .option( '--preview-url [string]', 'Disables the default storybook preview and lets your use your own' diff --git a/lib/core/src/server/manager/manager-webpack.config.js b/lib/core/src/server/manager/manager-webpack.config.js index 7cef204b9acb..9ec831cb9df6 100644 --- a/lib/core/src/server/manager/manager-webpack.config.js +++ b/lib/core/src/server/manager/manager-webpack.config.js @@ -83,9 +83,6 @@ export default ({ new CoreJSUpgradeWebpackPlugin({ resolveFrom: __dirname }), ].filter(Boolean), module: { - stats: { - errorDetails: true, - }, rules: [ babelLoader(babelOptions), {