Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-uninstalled-addons): ignore local addons #98

Merged
merged 1 commit into from Jul 12, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jul 12, 2022

Issue: #97

What Changed

This PR adds a fix for addons which are locally registered such as:

// .storybook/main.js
module.exports = {
  addons: [
    './my-addon/preset.cjs', // <-- ignored in the checks
    '@storybook/addon-essentials'
  ]
}

Checklist

Check the ones applicable to your change:

  • Ran yarn update-all
  • Tests are updated
  • Documentation is updated

Change Type

Indicate the type of change your pull request is:

  • maintenance
  • documentation
  • patch
  • minor
  • major

@yannbf yannbf added the patch Increment the patch version when merged label Jul 12, 2022
@yannbf yannbf merged commit 193c9b0 into main Jul 12, 2022
@yannbf yannbf deleted the fix/ignore-local-addons branch July 12, 2022 14:20
@github-actions
Copy link

🚀 PR was released in v0.6.1 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant